Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing outdated references to Elasticsearch #26

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sdelliot
Copy link
Collaborator

@sdelliot sdelliot commented Dec 3, 2024

This PR updates the documentation to fix an outdated comment that Elasticsearch is installed with FIREWHEEL. Additionally, we fix a bug introduced by #14 which neglected to update the version for the Sphinx documentation.

@sdelliot sdelliot requested a review from mitchnegus December 3, 2024 20:44
@mitchnegus
Copy link
Collaborator

mitchnegus commented Dec 6, 2024

This looks good to me. I think I missed the fact that in #14 we actually got rid of the firewheel.__version__ variable. Do you think we might be able to restore that, but using the Importlib version accessor? I haven't used importlib in that way before (I've always opted for using a _version.py file) so I'm not sure what it's limitations are as far as being callable in the firewheel.__init__ module.

My thinking is just that I will often try to call <package>.__version__ on packages, especially when debugging, and so it's a nice convenience to have around. I'm happy to merge this PR as is and investigate ways to bring it back if need be. I don't want to hold this one up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants